test: Add more unit tests for add_to_list.
#2531
Conversation
iphydf
force-pushed
the
add-to-list-test
branch
3 times, most recently
from
6f9aeed
to
c4f92bf
Compare
iphydf
force-pushed
the
add-to-list-test
branch
5 times, most recently
from
a754eff
to
f229de2
Compare
iphydf
force-pushed
the
add-to-list-test
branch
from
f229de2
to
8fc557e
Compare
iphydf
force-pushed
the
add-to-list-test
branch
from
8fc557e
to
ea7570b
Compare
iphydf
force-pushed
the
add-to-list-test
branch
3 times, most recently
from
4f43c3b
to
a910f04
Compare
iphydf
force-pushed
the
add-to-list-test
branch
5 times, most recently
from
02ecdb9
to
9b2241e
Compare
iphydf
force-pushed
the
add-to-list-test
branch
2 times, most recently
from
c378cf2
to
b4d7bf4
Compare
iphydf
force-pushed
the
add-to-list-test
branch
3 times, most recently
from
5e56eba
to
c68aeac
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2531 +/- ##
==========================================
+ Coverage 68.97% 69.12% +0.14%
==========================================
Files 89 96 +7
Lines 27784 27983 +199
==========================================
+ Hits 19164 19343 +179
- Misses 8620 8640 +20 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
add-to-list-test
branch
2 times, most recently
from
22db489
to
8d3f656
Compare
|
Nit: modulo doesn't result in a uniform distribution, it gets skewed. Might not matter for testing though. |
iphydf
force-pushed
the
add-to-list-test
branch
from
8d3f656
to
1d4f10b
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @Green-Sky and @nurupo)
toxcore/crypto_core_test_util.cc line 51 at r2 (raw file):
Previously, nurupo wrote…
Nit: modulo doesn't result in a uniform distribution, it gets skewed. Might not matter for testing though.
C++' random library has random number generators andstd::uniform_int_distribution()too, wonder why they weren't used here.
Added a comment. I'll test/benchmark the C++ stdlib stuff later. For now, this is a very simple and fast implementation intended to be exactly that.
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @Green-Sky and @nurupo)
toxcore/crypto_core_test_util.cc line 51 at r2 (raw file):
Previously, iphydf wrote…
Added a comment. I'll test/benchmark the C++ stdlib stuff later. For now, this is a very simple and fast implementation intended to be exactly that.
I guess LCG is the same as I put above. Maybe I'll refactor it tomorrow, or otherwise it'll be done in the next round of refactorings.
iphydf
force-pushed
the
add-to-list-test
branch
3 times, most recently
from
ea3a53c
to
00c81fb
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @Green-Sky and @nurupo)
toxcore/crypto_core_test_util.cc line 51 at r2 (raw file):
Previously, iphydf wrote…
I guess LCG is the same as I put above. Maybe I'll refactor it tomorrow, or otherwise it'll be done in the next round of refactorings.
I've decided to use C++ :P. Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @Green-Sky)
|
FYI was just pointing out something I noticed while skimming through the PR, don't plan on seriously reviewing it so don't hold the PR waiting on my review approval. |
iphydf
force-pushed
the
add-to-list-test
branch
from
00c81fb
to
afc38f2
Compare
This change is